Closed lauragift21 closed 4 years ago
This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/datopian1/portal/nioyvp6by ✅ Preview: https://portal-git-setup-integration-tests-with-cypress.datopian1.vercel.app
@lauragift21 I've added number of comments above.
How the CI works? I've seen github actions and Travis.. Why are we using both?
@anuveyatsu I added GitHub Actions first before seeing you requested doing the setup for Travis CI. We can take GitHub Actions out if it's not necessary.
@anuveyatsu I added GitHub Actions first before seeing you requested doing the setup for Travis CI. We can take GitHub Actions out if it's not necessary.
@anuveyatsu i think github actions by default atm (and no travis) unless big reason not to, wdyt?
@rufuspollock @lauragift21 I only mentioned Travis because Cypress had official docs about setting up Travis. If we can use GitHub actions to run Cypress then no problem at all.
@lauragift21 is it running with GitHub actions?
Alright. Yeah it is running with GitHub Actions. I'll suggest we can have both configured it's good to have double checks wdyt? @rufuspollock @anuveyatsu
@lauragift21 no, we don't want to maintain both of them. Let's remove Travis then.
@lauragift21 I've added new comments.
@lauragift21 any updates here?
@anuveyatsu I'll resolve these comments today. I was out on Friday.
@anuveyatsu Can you review this so that we can merge it tomorrow?
LGTM.
fixes:#21