[#41] Refactor Code - Githubissues

datopian / portal.js.bak

🌀 The JS data presentation framework. For a single dataset to a full catalog.

https://portal-78qurbwf9-datopian1.vercel.app/

MIT License

22 stars 2 forks source link

[#41] Refactor Code #47

Closed tavareshansen closed 4 years ago

tavareshansen commented 4 years ago

[x] It seems like they're trying to use typescript, but no types defined. Actually, it's not typescript.
[x] Implement code linting e.g. use eslint?
[x] Do not use array index as key when rendering list
[x] Create and use custom hooks/Context API for managing 3rd party libraries. e.g. apollo-client initializer defined in lib

fixes: #41

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/datopian1/portal/lwhq5hwg6 ✅ Preview: https://portal-git-enh-41-refactor-code.datopian1.vercel.app

tavareshansen commented 4 years ago

@rufuspollock @abhishekgahlot Please review this PR, which fixes #41 .

anuveyatsu commented 4 years ago

LGTM :+1: