search

datreeio / action-datree

Github action that runs the Datree CLI
MIT License
24 stars 15 forks source link

new action summary produces mistaken metadata #16

Closed gilbahat closed 1 year ago

gilbahat commented 2 years ago

There are 2 issues with the github action summary:

  1. excluded rules still appear as failed in the summary. this makes it really hard to tune what issues have been successfully excluded.
  2. garbage metadata appears in rule failures. it seems like the first metadata name is picked up and replicated across the board, or something of that sorts. either way it is entirely incorrect and does not match source files.
hadar-co commented 2 years ago

Hi @gilbahat thanks for opening an issue, is the repo in which this happened public? An example of these issues will help us resolve them.

gilbahat commented 2 years ago

unfortunately it is not. I will try to see if I can get some examples from non-properietary components.

gilbahat commented 2 years ago

Screen Shot 2022-10-12 at 18 01 04 Screen Shot 2022-10-12 at 18 00 46

there we go. as you can see, the in-job run shows that cloudflared has been successfully excluded. however, it still looks like an error in the job summary. you can also see that metadata refers to 'gatekeyper', a totally different component which is not present in the cloudflared yamls.

hadar-co commented 1 year ago

There was a bug where skipped files were not presented in the output, it is now fixed:)