search

datreeio / admission-webhook-datree

Datree offers cluster integration that allows you to validate your resources against your configured policy upon pushing them into a cluster, by using an admission webhook.
https://datree.io/
Apache License 2.0
24 stars 10 forks source link

[FEATURE REQUEST]: Improvement of the chart #308

Closed alifiroozi80 closed 1 year ago

alifiroozi80 commented 1 year ago

Hello all,

First, Thank you for this amazing project.

I have some suggestions for this chart to be better.

1) Add the imagePullSecrets field. 2) Access to change all images repository to another repository from the values file. 3) Add support for Hashicorp Vault to pull the TOKEN

For this limitation especially the number 1 and 2 I decided to install the Datree with kubectl rather than with its Chart.

eyarz commented 1 year ago

@alifiroozi80 changing the image repository via the Chart is already available here & here :)

Regarding adding imagePullSecrets and Hashicorp Vault support, this sounds like a legit feature request, so we will label this task "up for grab" for the community (or even you 😉) to submit a PR for that.

myishay commented 1 year ago

For whoever wants to grab this, here is a hint on how to add imagePullSecrets: https://v3.helm.sh/docs/howto/charts_tips_and_tricks/#creating-image-pull-secrets

alifiroozi80 commented 1 year ago

Hello @eyarz and @myishay Thank you so much for your responses, and sorry for my delayed response. I'm going to work on it and open a PR.

alifiroozi80 commented 1 year ago

I opened a PR here, Thanks.

alifiroozi80 commented 1 year ago

The private repo support was (merged](https://github.com/datreeio/admission-webhook-datree/pull/328). Thank you all🍻