Improve test command coverage for networking use cases

datreeio / datree

Prevent Kubernetes misconfigurations from reaching production (again 😤 )! From code to cloud, Datree provides an E2E policy enforcement solution to run automatic checks for rule violations. See our docs: https://hub.datree.io

https://datree.io

Apache License 2.0

6.39k stars 363 forks source link

Improve test command coverage for networking use cases #382

Open noaabarki opened 2 years ago

noaabarki commented 2 years ago

Describe the solution you'd like Add tests for networking failures flows in test command datree test <path>

Basic use cases to cover:

Failed to create evaluation

should create evaluation → meaning to call CreateEvaluation
should not request evaluation → meaning not to call Evaluate
should print mocked errors.

Failed to request evaluation

should create evaluation → meaning to call CreateEvaluation
should request evaluation → meaning to call Evaluate with returned evaluationID
should print mocked errors.

Requirements Golang basic level.

Kanika637 commented 2 years ago

I would like to work on this @noaabarki

noaabarki commented 2 years ago

@Kanika637, it's yours 💪🏻

adifayer commented 2 years ago

@Kanika637 Are you still working on this issue, or can we reassign it?😊

Kanika637 commented 2 years ago

Hey @adifay, actually I could not get hold of the issue. You can reassign it, sorry for the inconvenience.

KiranSatyaRaj commented 1 year ago

Hey @noaabarki, can you send me the slack invitation, I need to troubleshoot some issues I have while installing datree, and also to discuss this GitHub issue, I want to take it up.

noaabarki commented 1 year ago

Hi @KiranSatyaRaj, you got it!

This is the invite URL for Datree Slack channel: https://join.slack.com/t/datreecommunity/shared_invite/zt-1kaxe67uc-o0uO3EuK3kxjV3PSeqe~ZA.

KiranSatyaRaj commented 1 year ago

Hey @noaabarki, I didn't work with Git much and had less idea on how to deal with it, all these days I was learning Git and blogging it along the way, I'm back now and will start working on this issue, so far I got a hold of this if there's anything I'm stuck with I'll get back to you, thanks Noaa

Bharadwajshivam28 commented 7 months ago

Hey @noaabarki Can I work on this if no one is working?

What I understand from the issue is that-

We have to add tests based on- Test case 1st- A scene where evaluation fails use the function CreateEvaluation and make it return an error

Test case 2nd- system does not proceed to request evaluation as our evaluation failed check that Evaluate function not gets called Check that test gets captured and prints expected error

Test case 3th- Creating an evaluation is successful Call Evaluate function with evaluationID

having a small doubt in which directory I need to create the test file? Like We need to have a test file in which the test scene will be there