Read test commands flags from ./config.yaml file

[noaabarki]

Describe the solution you'd like

Read all test command’s flags from both command and the config file(~/.datree/config.yaml). The main feature is to allow users to set permanent yet custom flags in their config local settings.

“How to implementation” Suggestion

• Make sure all flags and options are in TestCommandFlags(wrap TestCommandFlags in TestCommandOptions as you see best).
• Change localConfig.GetLocalConfiguration() to return all the options from ./config.yaml file.

• Use GetLocalConfiguration() outside the scope of Cobra’s command RunE and initiate flags with local config. Eventually, the outcome should be something like

  // get local config options from local.yaml file
  localConfig := context.LocalConfig.GetLocalConfiguration()
  // initiate flags with localConfig settings
  flags := NewTestCommandFlags(localConfig)
  
  testCommand := &cobra.Command{
          ...
          RunE: func(cmd *cobra.Command, args []string) error {...},
      }
  
      // overwrite flags with the command's execution flags
      testCommandFlags.AddFlags(testCommand)
      return testCommand

Requirements Golang basic level.

[RishiKumarRay]

Do we have to just paste this code

[laneia]

Hey @noaabarki I’d be interested in taking this on

[noaabarki]

Hi @laneia! That's amazing, you got it :)

[dimabru]

Will this cause us to override the flags without the ability to change it via the cli?

To be more specific, I will be able to manually add schema-version flag to config.yaml but will not have the ability to use the cli to override it using datree config set schema-version Or even check what is set using datree config get schema-version

[royhadad]

Will this cause us to override the flags without the ability to change it via the cli?

To be more specific, I will be able to manually add schema-version flag to config.yaml but will not have the ability to use the cli to override it using datree config set schema-version Or even check what is set using datree config get schema-version

As with most tools, I think we want the inline flags to merge & override the flags from config.yaml

[naorpeled]

@noaabarki I would like to work on this issue :)

[noaabarki]

You are the best! 🥳 It's yours.

[naorpeled]

Hey @noaabarki, didn't have much time to work on this task in the past few weeks :(

Wanted to get it done within the day that I was assigned but got a bit stuck, will try to get it done this week.

[amustaque97]

@noaabarki is anyone working on this issue?

[royhadad]

@amustaque97 Nope, feel free to give it a shot :)

[Abhi-y2003]

@noaabarki is there anyone working on this issue? I would like to work on this : )

[eyarz]

@Abhi-y2003 go for it!