search

datreeio / datree

Prevent Kubernetes misconfigurations from reaching production (again 😤 )! From code to cloud, Datree provides an E2E policy enforcement solution to run automatic checks for rule violations. See our docs: https://hub.datree.io
https://datree.io
Apache License 2.0
6.39k stars 363 forks source link

Replace colors rendering package for better Windows support #680

Open myishay opened 2 years ago

myishay commented 2 years ago

Is your feature request related to a problem? Please describe. Colors printing in Windows are being printed with strange charactest like this for example: Screen Shot 2022-06-12 at 12 02 18

Describe the solution you'd like Currently we are using https://github.com/fatih/color for color rendering. From a quick check I have made, using https://github.com/jwalton/gchalk would solve our problem on Windows machines.

Describe alternatives you've considered Another option would be debugging why we see those weird characters, as they were not rendered in previous versions.

myishay commented 2 years ago

I found the reason why the color support in Windows had a regression and added a fix here: https://github.com/datreeio/datree/pull/681

I still think it would be better using gchalk since it will make the use of a special output when printing redundant