datreeio / helm-datree

A Helm plugin to validate charts against the Datree's CLI tool
https://hub.datree.io/integrations
MIT License
113 stars 26 forks source link

Allow use with other installations of helm #23

Closed mvarendorff closed 2 years ago

mvarendorff commented 2 years ago

Is your feature request related to a problem? Please describe.

I am using the helm3 plugin/addon of microk8s which is run using microk8s helm3; for easier personal use I just aliased that to helm but run.sh doesn't pick that up causing the datree plugin to not compile the chart which in turn causes a "No files detected" error since this line (specifically helm show chart) fails as the command isn't known:

https://github.com/datreeio/helm-datree/blob/c4146ef33895739b5634a1e8a8e524159a5d3f3e/scripts/run.sh#L16

Describe the solution you'd like

Some flag / env variable for the script to provide an alternative path / way of calling helm to allow executing helm that is prebundled with other tools and thus requires a different command to run.

Describe alternatives you've considered

Additional context -

dimabru commented 2 years ago

Hi @geisterfurz007, Thanks a lot for reporting this! I'm marking this issue as up for grabs

dimabru commented 2 years ago

@geisterfurz007 BTW, if you were able to find the issue location and suggest a solution I think you are definitely skilled enough to fix this yourself :) If you'd like to take this on, please let me know. We can schedule a zoom call and talk about a possible solution

mvarendorff commented 2 years ago

I think I might actually have something in mind; I will try around with it later and open a PR if it works; otherwise I Will gladly come back to the zoom call offer, thanks a lot!