datreeio / helm-datree

A Helm plugin to validate charts against the Datree's CLI tool
https://hub.datree.io/integrations
MIT License
113 stars 26 forks source link

Add pre-commit-hooks feature for helm-datree #33

Closed angelwcrypto closed 2 years ago

angelwcrypto commented 2 years ago

Is your feature request related to a problem? Please describe. I would not want to commit to the repos every time I work with fixing the policies. So pre-commit-hooks are useful to Helm Charts users

Describe the solution you'd like It would be nice to have pre-commit hooks feature as well for the Helm Chart users.

Something like this:

Thank you!

eyarz commented 2 years ago

@angelwcrypto why did you decide to close this issue?

angelwcrypto commented 2 years ago

@eyarz I thought I have some typos

angelwcrypto commented 2 years ago

Sorry about that, could you help with taking a look into a possible enhancement for the helm datree? I must say that I like the simplicity of the tool a lot.

eyarz commented 2 years ago

Sure, but why don't you open a PR with a configured .pre-commit-hooks.yaml file? I'm not a pre-commit expert, but I'm a little familiar with that for Datree's CLI project.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.