search

datrs / flat-tree

Map a binary tree to a vector.
Apache License 2.0
53 stars 10 forks source link

Is uncle used? #12

Closed ralphtheninja closed 6 years ago

ralphtheninja commented 6 years ago

I noticed that uncle was implemented, which isn't part of the js api. Is that used somewhere?

yoshuawuyts commented 6 years ago

It's not afaik, but having it in there can probably be useful sometimes. Dead code elimination strips it for us at compile time ✨

ralphtheninja commented 6 years ago

Maybe I should explain why I made this issue in the first place. Things that "might be useful sometimes" to me are bad since they add more things to think about. I think there are functions in mafintosh/flat-tree that aren't used either, so when porting that lib to other languages (e.g. this lib), functions are being re-implemented which shouldn't need to be re-implemented.

It's not the end of the world though. Just my 2 cents :)