added "path is a dir" check in Feed::open

datrs / hypercore

Secure, distributed, append-only log

https://docs.rs/hypercore

Apache License 2.0

326 stars 37 forks source link

added "path is a dir" check in Feed::open #120

Closed khodzha closed 3 years ago

khodzha commented 4 years ago

I suppose this is a 🐛 bug fix

Checklist

[x] tests pass
[x] tests and/or benchmarks are included
[ ] documentation is changed or added

Context

this is not related to any github issues

Semver Changes

no changes? idk

khodzha commented 4 years ago

also the question regarding mkdirp, should we do it if dir at the path doesnt exist and there is no file with same name?

right now i think Feed::open does create a dir

bltavares commented 4 years ago

IMO I think it would be nice to have this as a helpful attempt to make it work 👍

khodzha commented 4 years ago

hopefully made try_open_missing_dir test more crossplatform

bltavares commented 3 years ago

The tests are failing but that is a new clippy rule that is affecting previous changes. I will merge this PR and fix the tests on another issue to not block you more.