datrs / hypercore

Secure, distributed, append-only log
https://docs.rs/hypercore
Apache License 2.0
327 stars 37 forks source link

Update merkle-tree-stream requirement from 0.7.0 to 0.8.0 #46

Closed dependabot-preview[bot] closed 5 years ago

dependabot-preview[bot] commented 5 years ago

Updates the requirements on merkle-tree-stream to permit the latest version.

Changelog *Sourced from [merkle-tree-stream's changelog](https://github.com/datrs/merkle-tree-stream/blob/master/CHANGELOG.md).* > ## 2018-10-28, Version 0.8.0 > ### Commits > - [[`b6096eacff`](https://github.com/datrs/merkle-tree-stream/commit/b6096eacffc96765271307cbf30bd613b414b4af)] (cargo-release) version 0.8.0 (Yoshua Wuyts) > - [[`770347ec82`](https://github.com/datrs/merkle-tree-stream/commit/770347ec82cdd5bf5b207088be2535f76364576f)] Use NodeKind enum instead of Option for PartialNode data ([#18](https://github-redirect.dependabot.com/datrs/merkle-tree-stream/issues/18)) (Scott Trinh) > - [[`04b163a5d1`](https://github.com/datrs/merkle-tree-stream/commit/04b163a5d1ccb06f995576152280bde5241c0ef4)] Update changelog (Yoshua Wuyts) > > ### Stats > ```diff > CHANGELOG.md | 25 +++++++++++++++++++++++++ > Cargo.toml | 2 +- > examples/main.rs | 7 +++++-- > src/default_node.rs | 6 +++--- > src/lib.rs | 24 +++++++++++++++--------- > src/partial_node.rs | 14 +++++++++++--- > tests/lib.rs | 20 +++++++++++--------- > 7 files changed, 71 insertions(+), 27 deletions(-) > ``` > > > ## 2018-10-17, Version 0.7.0 > ### Commits > - [[`8fe517e043`](https://github.com/datrs/merkle-tree-stream/commit/8fe517e0432d35563c3f89956a7065ec3cbdb9ef)] (cargo-release) version 0.7.0 (Yoshua Wuyts) > - [[`3468de73e7`](https://github.com/datrs/merkle-tree-stream/commit/3468de73e7dc011838d762dc3be18e7cea026049)] Fix features ([#17](https://github-redirect.dependabot.com/datrs/merkle-tree-stream/issues/17)) (Yoshua Wuyts) > - [[`961426a0b4`](https://github.com/datrs/merkle-tree-stream/commit/961426a0b42cebdfafc75a6d6001a03f16929019)] Add doctest for MerkleTreeStream ([#16](https://github-redirect.dependabot.com/datrs/merkle-tree-stream/issues/16)) (Kuba) > - [[`42eb089703`](https://github.com/datrs/merkle-tree-stream/commit/42eb0897034fae63f443364b82c1115f15cc16aa)] Update rust_sodium requirement from 0.7.0 to 0.10.0 ([#14](https://github-redirect.dependabot.com/datrs/merkle-tree-stream/issues/14)) (dependabot[bot]) > - [[`f2552f963f`](https://github.com/datrs/merkle-tree-stream/commit/f2552f963f4d29d7a9da5df59b66e579d19782b1)] Update quickcheck requirement from 0.6.2 to 0.7.1 ([#15](https://github-redirect.dependabot.com/datrs/merkle-tree-stream/issues/15)) (dependabot[bot]) > - [[`2543672317`](https://github.com/datrs/merkle-tree-stream/commit/2543672317e82e3879fc7942cec74d6e83b49c37)] Keep up with modern times in clippy invocation ([#13](https://github-redirect.dependabot.com/datrs/merkle-tree-stream/issues/13)) (Szabolcs Berecz) > - [[`bfe9fa5630`](https://github.com/datrs/merkle-tree-stream/commit/bfe9fa56307a8db8245abb6d32e8ecd944d1e980)] Update .github (Yoshua Wuyts) > > ### Stats > ```diff > .github/ISSUE_TEMPLATE.md | 40 +---------- > .github/ISSUE_TEMPLATE/bug_report.md | 23 ++++++- > .github/ISSUE_TEMPLATE/feature_request.md | 30 ++++++++- > .github/ISSUE_TEMPLATE/question.md | 18 +++++- > .travis.yml | 5 +- > Cargo.toml | 7 +-- > examples/main.rs | 43 ++++-------- > src/lib.rs | 113 +++++++++++++++++++++++++++++-- > tests/lib.rs | 41 ++++------- > 9 files changed, 221 insertions(+), 99 deletions(-) > ```
Commits - See full diff in [compare view](https://github.com/datrs/merkle-tree-stream/commits/0.8.0)


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

If all status checks pass Dependabot will automatically merge this pull request.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot.
yoshuawuyts commented 5 years ago

Uh oh.

    Finished dev [unoptimized + debuginfo] target(s) in 0.12s
     Running target/debug/deps/hypercore-3063c0c91a281f85

running 5 tests
test crypto::hash::tests::leaf_hash ... ok
test crypto::hash::tests::parent_hash ... ok
test crypto::hash::tests::root_hash ... ok
test storage::should_detect_zeroes ... ok
test crypto::key_pair::can_verify_messages ... ok

test result: ok. 5 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

     Running target/debug/deps/bitfield-42578a09f82ab4f9

running 2 tests
test get_total_positive_bits ... ok
test set_and_get ... ok

test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

     Running target/debug/deps/compat-611c581921e9a306

running 4 tests
test deterministic_data_and_tree_after_replication ... ignored
test deterministic_signatures_after_replication ... ignored
test deterministic_signatures ... FAILED
test deterministic_data_and_tree ... FAILED

failures:

---- deterministic_signatures stdout ----
thread 'deterministic_signatures' panicked at 'internal error: entered unreachable code', src/crypto/merkle.rs:29:27
note: Run with `RUST_BACKTRACE=1` for a backtrace.

---- deterministic_data_and_tree stdout ----
thread 'deterministic_data_and_tree' panicked at 'internal error: entered unreachable code', src/crypto/merkle.rs:29:27

failures:
    deterministic_data_and_tree
    deterministic_signatures

test result: FAILED. 0 passed; 2 failed; 2 ignored; 0 measured; 0 filtered out

error: test failed, to rerun pass '--test compat'

I think this means merkle-tree-stream can take branches it shouldn't be taking, which is not a good sign.

yoshuawuyts commented 5 years ago

Ah okay, I swapped a None with an unreachable!() which changed the functionality of the code entirely haha.