datrs / hypercore

Secure, distributed, append-only log
https://docs.rs/hypercore
Apache License 2.0
332 stars 37 forks source link

remove builder pattern #80

Closed ZhouHansen closed 4 years ago

ZhouHansen commented 5 years ago

https://github.com/datrs/hypercore/issues/72

bltavares commented 4 years ago

Hi @ZhouHansen, thanks for the PR.

I'm cleaning up open PRs to help new contributors. This PR has a few conflicts, and according to the discussion on #72, removing the builder does not seem to be the way to go.

Using builders are documented on several API Guidelines:

While currently we have a few options that would make Feed trivial to build, the discussion on #109 and #113 might require more complex builders to allow multiple storage locations.

I will close this PR as there are conflicts, and we could revisit topic after the storage changes to see if maintaining a builder is worth vs the complexity of initializing a new Feed