search

datrs / random-access-storage

Abstract interface to implement random-access instances.
Apache License 2.0
14 stars 7 forks source link

rename Sync trait #1

Closed yoshuawuyts closed 6 years ago

yoshuawuyts commented 6 years ago

We could probably rename it to Synchronous or something else. It currently conflicts with the std https://doc.rust-lang.org/beta/std/marker/trait.Sync.html trait which is available on almost every struct.

yoshuawuyts commented 6 years ago

Alternatively we could drop the Sync bit entirely, and just swap to an async implementation once Futures hit 1.0.0. Use semver major to mark the switch.

Feels like it might be a bit neater. We could then rename the struct to Storage or something.

yoshuawuyts commented 6 years ago

impl RandomAccessStorage for Storage