datrs / random-access-storage

Abstract interface to implement random-access instances.

Apache License 2.0

13 stars 7 forks source link

Fixes #7: Make RandomAccess always open #11

Closed khernyo closed 6 years ago

khernyo commented 6 years ago

This PR removes the open() method and the now redundant RandomAccess struct.

This does not follow exactly #7 as there is no new struct/trait for the unopened state. It turns out that adding that would complicate things for no benefit IMO.

Checklist

[x] documentation is changed or added

Context

7

Semver Changes

Minor

khernyo commented 6 years ago

WIP because I want to submit a couple of dependent PRs to show how it all will look. Also, it has a bit less documentation than before, so I will fix that. Otherwise, it should be good to go.

khernyo commented 6 years ago

See the necessary changes to the dependent libs: datrs/random-access-disk#13, datrs/random-access-memory#4, datrs/hypercore#26

khernyo commented 6 years ago

All right, it's good to go. Please merge this and release a new version so that I can reference it in the other two random-access projects. I will do the cleanup on the other PRs tomorrow.

yoshuawuyts commented 6 years ago

v0.6.0 :tada: