search

dattn / dnd-grid

A vuejs grid with draggable and resizable boxes
307 stars 48 forks source link

Touch enabled #40

Closed irongollem closed 5 years ago

irongollem commented 5 years ago

This patch adds touch listeners for the drag and drop handle. Resize doesn't yet work. Will try and implement Pinch for that next

dattn commented 5 years ago

Thank you for this pull request.

Could you please remove the dist folder from git, and add an "prepublishOnly" script to the package.json to force a build before publishing the package. Instead of removing the dist folder from the .gitignore file, add an .npmignore file with the same content as the .gitignore file but with the dist folder removed.

Why did you remove the package-lock file from the repo ?

irongollem commented 5 years ago

Hi Dattn, this is my first pr over github so didn't account for the system updating the merge request on its own. I've made some changes (like the temporary dist and package-lock since we use yarn and a yarn-lock file) for local usage while waiting for this one to update :), aparently those now ended up in the PR as well :)

I'll adjust the file to properly reflect a PR.

Not sure what do put in the prepublish script.

irongollem commented 5 years ago

@dattn Not sure how to undo the package-lock deletion, but other than that I think this should be alright?

irongollem commented 5 years ago

@dattn can you review my last changes and if sufficient merge?

dattn commented 5 years ago

Sorry for the long wait, i will take a look tonight.