Closed Finix1979 closed 1 year ago
If any error occurs in snap_trace_bio, we should still issue original write io along with setting the snap device to failure mode.
Besides that, call tp_get(tp) only when the clone finishes successfully, otherwise, tp can not get a chance to be destroyed.
To simplify the error handling, use bio_list to gather all new_bio and submit them in one loop.
Signed-off-by: Finix yancw@info2soft.com
Looks good, thanks!
dakotarwilliams
commented
1 year ago dakotarwilliams
commented
1 year ago
If any error occurs in snap_trace_bio, we should still issue original write io along with setting the snap device to failure mode.
Besides that, call tp_get(tp) only when the clone finishes successfully, otherwise, tp can not get a chance to be destroyed.
To simplify the error handling, use bio_list to gather all new_bio and submit them in one loop.
Signed-off-by: Finix yancw@info2soft.com