datto / dattobd

kernel module for taking block-level snapshots and incremental backups of Linux block devices
GNU General Public License v2.0
560 stars 120 forks source link

initialize snap device for cow #367

Closed natalia-zelazna closed 1 month ago

natalia-zelazna commented 3 months ago

Hi, this is the complete work covering crash during reboot (handle_bdev_mount_event during transition from active to dormant state). This solution provides proper handling of cow_file_extens. It should solve #365

Swistusmen commented 2 months ago

What is the purpose of last commit? From what I see it in best case doesn't change anything because dentry and vfsmount are NULL when you do path_put so they just do return

natalia-zelazna commented 2 months ago

1) to remove direct dependency form version number in the code - I went throug older supported distros and dattobd works fine with kernel_path instead of user_path_at 2) to consistently (with other errors that may happen in this function) go to the error handling part without checking all other possible failures on the way.

st-matskevich commented 1 month ago

Closed as work will be completed in https://github.com/datto/dattobd/pull/375