Closed YaoYinYing closed 5 months ago
@dauparas are you considering merging this? This is a big improvement in terms of usability and probably many people would benefit from it!
@YaoYinYing Having an entry point in the toml would make it even nicer (I did not check but just looked at your example above!). Does your code allow to use custom checkpoints?
Thanks for great work.
Sincerly, P.
@paoslaos Hi I have update code for the feature you need and validated this change via CI tests.
Thanks for such nice advice!
@YaoYinYing This is truly incredible and good engineering work, thank you!
Edit: to clarify what I mean because I dont see the changes (yet?):
In the toml, a single line like:
[project.scripts]
ligandmpnn = "ligandmpnn.scripts.run:main"
would be nice. This would require the scripts dir to be under ligandmpnn which would break existing code usage. Slight duplication would not be too bad. Or slightly refactor the scripts file in root to use this entrypoint as well. What do you think?
Edit2: (Happy to help with PR)
Sincerely, P.
@paoslaos Sorry for this misunderstanding. Inference command line shortcut will be more elegant then repo cloning and script calling. LGTM. CI tests look okay too: https://github.com/YaoYinYing/LigandMPNN/actions/runs/9397959040.
@YaoYinYing nice!
I think we had an misunderstanding, but the result is exactly what I meant! Very nice! Will definitely use this in my work!
LGTM
This PR is outofdated and closing. Use the latest branch instead.
Hi, this PR helps LigandMPNN being like
a pip-installable package:
using
hydra
for config management:ligandmpnn/config/ligandmpnn.yaml
.run.py
/score.py
without changing the orginal libraries (*_utils
)35
mkdir -p customized_weight_dir_remote ligandmpnn \ sampling.seed=111 \ weight_dir="customized_weight_dir_remote" \ checkpoint.customized.url='https://files.ipd.uw.edu/pub/ligandmpnn/proteinmpnn_v_48_020.pt' \ input.pdb="./inputs/1BC8.pdb" \ output.folder="./outputs/customized_weight_dir_remote"
ls customized_weight_dir_remote
36
mkdir -p customized_weight_dir_remote_hash ligandmpnn \ sampling.seed=111 \ weight_dir="customized_weight_dir_remote_hash" \ checkpoint.customized.url='https://files.ipd.uw.edu/pub/ligandmpnn/proteinmpnn_v_48_010.pt' \ checkpoint.customized.known_hash='md5:4255760493a761d2b6cb0671a48e49b7' \ input.pdb="./inputs/1BC8.pdb" \ output.folder="./outputs/customized_weight_dir_remote_hash"
ls customized_weight_dir_remote_hash
Feel free to edit if you find this PR is cool!