add connect() and hash command wrappers

daurnimator / lredis

A redis client for lua

MIT License

43 stars 7 forks source link

add connect() and hash command wrappers #3

Open slact opened 7 years ago

slact commented 7 years ago

redis-url-parsing connect() and HGETALL and HMGET wrappers to return hash entries in a table

coveralls commented 7 years ago

Coverage decreased (-13.06%) to 71.296% when pulling a2d4c629bc5280d4acc0ff6094d77d6bdaa836dd on slact:master into 677cb3ed27219b2cf7e08290926c1769d08ae3f2 on daurnimator:master.

coveralls commented 7 years ago

Coverage increased (+1.8%) to 86.111% when pulling 4464bf4bb0b0a8010021de7c30f0e910527e7233 on slact:master into 677cb3ed27219b2cf7e08290926c1769d08ae3f2 on daurnimator:master.

coveralls commented 7 years ago

Coverage increased (+2.2%) to 86.547% when pulling 364660aafcc2553942a781cbbb1fe8dfddc7456b on slact:master into 677cb3ed27219b2cf7e08290926c1769d08ae3f2 on daurnimator:master.

coveralls commented 7 years ago

Coverage increased (+2.2%) to 86.607% when pulling 7ab9b8f76599a23cdbe5c9acaab1772e2e7aa1b3 on slact:master into 677cb3ed27219b2cf7e08290926c1769d08ae3f2 on daurnimator:master.

coveralls commented 7 years ago

Coverage increased (+1.7%) to 86.036% when pulling e29b6e48323afd6e150dde41915e53a5223cd15c on slact:master into 677cb3ed27219b2cf7e08290926c1769d08ae3f2 on daurnimator:master.

daurnimator commented 7 years ago

It seems that redis does have a provisional uri scheme: https://www.iana.org/assignments/uri-schemes/prov/redis Also note the rediss scheme which is used for redis over TLS (see https://www.iana.org/assignments/uri-schemes/prov/rediss)

Please try and implement everything under the 'Scheme semantics' section.

coveralls commented 7 years ago

Coverage increased (+1.5%) to 85.845% when pulling 4654ae26cb5d010769008369f2f1ac4adb3389e8 on slact:master into 677cb3ed27219b2cf7e08290926c1769d08ae3f2 on daurnimator:master.

coveralls commented 7 years ago

Coverage increased (+1.9%) to 86.239% when pulling e329978711ba23b84a7e155d89b08bb9b8f7dddd on slact:master into 677cb3ed27219b2cf7e08290926c1769d08ae3f2 on daurnimator:master.

slact commented 7 years ago

Didn't realize someone's already added a provisional rediss, even though redis still doesn't support TLS connections. According to https://github.com/antirez/redis/issues/2178 , redis-rb already added support for it, so I don't see why lredis should skip it. I'll add this in.

coveralls commented 7 years ago

Coverage increased (+2.7%) to 87.029% when pulling 1691d1af859fb5efc46282d9803d37f64e1d3ff2 on slact:master into 677cb3ed27219b2cf7e08290926c1769d08ae3f2 on daurnimator:master.