misplaced argument in h2_stream?

daurnimator / lua-http

HTTP Library for Lua. Supports HTTP(S) 1.0, 1.1 and 2.0; client and server.

https://daurnimator.github.io/lua-http/

MIT License

795 stars 81 forks source link

misplaced argument in h2_stream? #158

Closed Mehgugs closed 3 years ago

Mehgugs commented 5 years ago

On line 1389 self:write_data_frame is called with timeout as the third argument, but the third argument should be an integer describing how much padding to add?

Definition vs. call: function stream_methods:write_data_frame(payload, end_stream, padded, timeout, flush)

self:write_data_frame(payload:sub(sent+1, sent+max_available), false, timeout)

This caused an error for me when sending a multipart payload.

daurnimator commented 5 years ago

I think your diagnosis is correct. Want to send a PR?

RyanSquared commented 4 years ago

Closed by #159 ?