search

dauxio / daux.io

Daux.io is an documentation generator that uses a simple folder structure and Markdown files to create custom documentation on the fly. It helps you create great looking documentation in a developer friendly way.
https://daux.io/
MIT License
794 stars 196 forks source link

HTML5shiv hard-coded to default theme #124

Closed JKingweb closed 5 years ago

JKingweb commented 5 years ago

The HTML5shiv JS file is hard-coded to the daux theme in the layout template. If a non-default theme directory not containing the daux theme is used, the shiv will not be found, and compatibility is (presumably) reduced.

I'm not certain of the best solution to the problem is, however.

onigoetz commented 5 years ago

Yes, I did it because it's wrapped in a conditional comment.

However the HTML5 Shiv is for

Internet Explorer 6-9, Safari 4.x (and iPhone 3.x), and Firefox 3.x.

Which are dead browsers now, I was thinking of removing this from the template altogether. What do you think ?

JKingweb commented 5 years ago

I think it's reasonable to move on. If removing that, though, I'd be interested in also removing Daux's reliance on jQuery, at least outside searching. It shouldn't be too hard to strike the right balance between compatibility and code cleanliness, since what it's being used for is today thoroughly commonplace. I'd be happy to write a patch.

onigoetz commented 5 years ago

That’s what I thougt as well for jQuery, however for the search I was thinking about trying preact. That would suit such a use case nicely with a small footprint