search

dauxio / daux.io

Daux.io is an documentation generator that uses a simple folder structure and Markdown files to create custom documentation on the fly. It helps you create great looking documentation in a developer friendly way.
https://daux.io/
MIT License
794 stars 196 forks source link

Single-page HTML export fails with incompatible getLinkRenderer #291

Closed gwittenburg closed 2 years ago

gwittenburg commented 2 years ago

Describe the bug Single-page HTML export fails with the following error:

Fatal error: Declaration of Todaymade\Daux\Format\HTMLFile\ContentTypes\Markdown\CommonMarkConverter::getLinkRenderer(League\CommonMark\Environment\Environment $environment) must be compatible with Todaymade\Daux\ContentTypes\Markdown\CommonMarkConverter::getLinkRenderer(Todaymade\Daux\Config $config) in /daux/libs/Format/HTMLFile/ContentTypes/Markdown/CommonMarkConverter.php on line 7

Regular (multi-page) HTML works fine for the same project.

To Reproduce Run the following command with the currently latest (v0.17.2) Docker image: docker run -it -w /build -v "$PWD":/build --rm daux/daux.io daux generate --format=html-file

Expected behavior Above command should generate single-page HTML output, given that multi-page works fine.

Screenshots n/a

Desktop (please complete the following information): Ubuntu 21.10

Smartphone (please complete the following information): n/a

Additional context n/a

onigoetz commented 2 years ago

Hi, I fixed the output of single-page in the master branch, it mostly works but anchors within pages might link incorrect to one another. I'll look into it next.

gwittenburg commented 2 years ago

Thanks so much, Stéphane!

onigoetz commented 2 years ago

Released in version 0.18.0

gwittenburg commented 2 years ago

Thanks, Stéphane, much appreciated!

Could there be a minor packaging issue regarding main.min.css (see https://github.com/dauxio/daux.io/issues/294)?