davatorium / rofi-blezz

MIT License
30 stars 2 forks source link

Feature Request: An option for selecting the section in the config to open. #1

Closed DMBuce closed 2 years ago

DMBuce commented 2 years ago

Blezz has a -d option to choose which dir in the config to open. As far as I can tell this is not possible with rofi-blezz, which always starts by displaying the first dir defined in the config.

Currently I am using a wrapper script for this functionality, but it would be nice if rofi-blezz had the feature baked in.

An example of how this would be useful: I have a config similar to the one below and use my wrapper script to bind Super+z to the "Main" dir, Super+m to the "Music" dir, and Super+p to the "Password" dir. Without the wrapper script I would have to have different copies of nearly identical config files, just with the order of the dirs changed. Which is not ideal.

Main:
dir(m,Music)
dir(p,Password)

Music:
act(m,Mpd,     music mps play )
act(p,Pandora, music pandora play )
act(r,Radio,   music radio play )
act(c,Choose,  music choose )

Password:
act(p,Password, rofi-pass copyPass)
act(c,Copy,     rofi-pass copyMenu)
act(l,Launch,   rofi-pass openUrl)
act(n,New,      rofi-pass --insert)
act(o,Other,    rofi-pass actionMenu)
DaveDavenport commented 2 years ago

sorry misread.

DaveDavenport commented 2 years ago

Please test fix. -blezz-directory takes the directory name.

DMBuce commented 2 years ago

Thanks! This works well in most cases, however if I pass the first dir to the -blezz-directory option, X freezes, rofi consumes 100% CPU and its memory balloons until it's OOM killed.

^_^ buce@football:rofi-blezz$ rofi -show blezz -modi blezz -auto-select -matching normal -theme-str  'window {width:50%;} * {columns:4;}' -blezz-directory Main
Killed

In the logs:

May 23 09:37:09 football kernel: Out of memory: Killed process 3136768 (rofi) total-vm:16220232kB, anon-rss:14729360kB, file-rss:304kB, shmem-rss:0kB, UID:1000 pgtables:31232kB oom_score_adj:0 May 23 09:37:09 football systemd[1]: session-45.scope: A process of this unit has been killed by the OOM killer. May 23 09:37:09 football kernel: oom_reaper: reaped process 3136768 (rofi), now anon-rss:0kB, file-rss:0kB, shmem-rss:0kB

DaveDavenport commented 2 years ago

owh fun :D , lets see

DaveDavenport commented 2 years ago

got it reproduced.. fun

DaveDavenport commented 2 years ago

hopefully fixed.. (its been way to long since I done anything on this plugin)

DMBuce commented 2 years ago

Works great, thanks a bunch!