davatorium / rofi-blezz

MIT License
30 stars 2 forks source link

Build problem - headers order #3

Closed LuchkoVladimir closed 1 year ago

LuchkoVladimir commented 2 years ago

Hi there, i had a problem with build, looks like:

$ make
make  all-am
make[1]: вход в каталог «/home/vlad/hobby/rofi-blezz/build»
  CC       src/blezz_la-blezz.lo
In file included from ../src/blezz.c:35:
/usr/include/rofi/mode-private.h:41:28: error: unknown type name 'Mode'
   41 | typedef void (*_mode_free)(Mode *data);
      |                            ^~~~
/usr/include/rofi/mode-private.h:55:48: error: unknown type name 'Mode'
   55 | typedef char *(*_mode_get_display_value)(const Mode *sw,
...

There is a patch, that helps me:

commit 6167a6c13d522e828cff2aa4d49ab6ade6819850 (HEAD -> master)
Author: Luchko Vladimir <vlad.luch@mail.ru>
Date:   Sun Aug 14 09:05:57 2022 +0700

    Fix build - rofi headers order

diff --git a/src/blezz.c b/src/blezz.c
index 91ee8b0..dbfcade 100644
--- a/src/blezz.c
+++ b/src/blezz.c
@@ -32,8 +32,8 @@
 #include <unistd.h>

 #include <rofi/helper.h>
-#include <rofi/mode-private.h>
 #include <rofi/mode.h>
+#include <rofi/mode-private.h>
 #include <rofi/rofi-icon-fetcher.h>

 G_MODULE_EXPORT Mode mode;

Thanx a lot for the great plugin :)

DaveDavenport commented 1 year ago

Fixed. (thx)