search

davatorium / rofi-blezz

MIT License
30 stars 2 forks source link

Can no longer use multiple keys for a hotkey #5

Open programmerHaaks opened 11 months ago

programmerHaaks commented 11 months ago

First, thank you for making rofi and rofi-blezz! It's an integral part of my workflow at work and at home.

There seems to have been a regression. Earlier, hotkeys could be multiple letters. So let's say I have a bunch of project I normally open in my IDE. I have the directory "IDE" with hotkey "i". Then I have the project "Bank" and "BankIntegrator". Earlier I could define Bank as "ba" and BankIntegrator as "bi". This seems to be no longer possible.

The issue seems to be the change introduced in to no longer lowercase the hotkey, but respect rofi's case sensitivity settings. The line is https://github.com/davatorium/rofi-blezz/blob/master/src/blezz.c#L150 where utf8_get_char is used to get a single character, discarding the rest. The change was done in 300f37f72b56d8d07cb3ae07415d607ec04ba985

DaveDavenport commented 11 months ago

That it worked in the past was more unintentional then planned. I copied the design of the orginal blezz that was single keypress.

I agree it might be nice to support multiple, a patch would be welcome. (not sure when I have time to look at this).