Pango markup is matched in search box

davatorium / rofi

Rofi: A window switcher, application launcher and dmenu replacement

https://davatorium.github.io/rofi/

Other

13.04k stars 609 forks source link

Pango markup is matched in search box #1023

Closed andrei-a-papou closed 4 years ago

andrei-a-papou commented 4 years ago

Version

Version: 1.5.4

Configuration

No user configuration at all.

Launch Command

echo -e '<span color="red">one</span>\n<span color="blue">two</span>\n' | rofi -p TEST -dmenu -markup-rows

Steps to reproduce

run the above command
type span into the search box

What behaviour you see

both items are matched due to Pango markup

rofi-span-problem

What behaviour you expect to see

no items should be matched

DaveDavenport commented 4 years ago

It currently does this. I never implemented parsing of it, because I was worried about performance issues. Should investigates this.

andrei-a-papou commented 4 years ago

I see. I just assumed it's a bug since the drun mode doesn't have this problem. Hopefully, fixing it for dmenu mode won't cause a performance hit.

I'm building a custom rofi-based app for JIRA, and it loads 1,000+ JIRA issues into rofi, all with Pango markup (colored arrows to indicate issue priorities, and more).

Would be willing to load-test any code that fixes this problem.

DaveDavenport commented 4 years ago

in drun the markup is added on display.. in dmenu it is the input and I don't have the original without markup.

It will be a performance hit, question is just how big.

DaveDavenport commented 4 years ago

Seems I fixed this a while back.

andrei-a-papou commented 4 years ago

thank you, seems to work well!

DaveDavenport commented 4 years ago

Thanks for confirming.

github-actions[bot] commented 3 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.