[BUG] Build failure on arch

[hughwilliams94]

Version

Version: 1.5.4-63-geb12ff23 (makepkg)

Configuration

rofi -h

Launch Command

Build fails on ninja -C build

Steps to reproduce

• Step 1 Recursively clone repo
• Step 2 meson setup build
• Step 3 ninja -C build

What behaviour you see

Build fails with the following message:

ninja: Entering directory `build'
[47/105] Compiling C object 'rofi@exe/source_helper.c.o'.
../source/helper.c: In function ‘cairo_image_surface_create_from_svg’:
../source/helper.c:1116:9: warning: ‘rsvg_handle_close’ is deprecated: Use 'rsvg_handle_read_stream_sync' instead [-Wdeprecated-declarations]
 1116 |         rsvg_handle_close ( handle, &error );
      |         ^~~~~~~~~~~~~~~~~
In file included from ../source/helper.c:50:
/usr/include/librsvg-2.0/librsvg/rsvg.h:192:14: note: declared here
  192 | gboolean     rsvg_handle_close  (RsvgHandle *handle, GError **error);
      |              ^~~~~~~~~~~~~~~~~
[72/105] Linking target rofi.
FAILED: rofi
cc  -o rofi 'rofi@exe/meson-generated_theme-lexer.c.o' 'rofi@exe/meson-generated_theme-parser.c.o' 'rofi@exe/meson-generated_.._resources.c.o' 'rofi@exe/source_rofi.c.o' 'rofi@exe/source_view.c.o' 'rofi@exe/source_mode.c.o' 'rofi@exe/source_keyb.c.o' 'rofi@exe/config_config.c.o' 'rofi@exe/source_helper.c.o' 'rofi@exe/source_timings.c.o' 'rofi@exe/source_history.c.o' 'rofi@exe/source_theme.c.o' 'rofi@exe/source_rofi-icon-fetcher.c.o' 'rofi@exe/source_css-colors.c.o' 'rofi@exe/source_widgets_box.c.o' 'rofi@exe/source_widgets_icon.c.o' 'rofi@exe/source_widgets_container.c.o' 'rofi@exe/source_widgets_widget.c.o' 'rofi@exe/source_widgets_textbox.c.o' 'rofi@exe/source_widgets_listview.c.o' 'rofi@exe/source_widgets_scrollbar.c.o' 'rofi@exe/source_xrmoptions.c.o' 'rofi@exe/source_rofi-types.c.o' 'rofi@exe/source_xcb.c.o' 'rofi@exe/source_dialogs_run.c.o' 'rofi@exe/source_dialogs_ssh.c.o' 'rofi@exe/source_dialogs_drun.c.o' 'rofi@exe/source_dialogs_dmenu.c.o' 'rofi@exe/source_dialogs_combi.c.o' 'rofi@exe/source_dialogs_window.c.o' 'rofi@exe/source_dialogs_script.c.o' 'rofi@exe/source_dialogs_help-keys.c.o' -Wl,--as-needed -Wl,--no-undefined -Wl,--start-group subprojects/libgwater/xcb/liblibgwater-xcb.a subprojects/libnkutils/libnkutils.a subprojects/libnkutils/libnkutils-bindings.a /usr/lib/libglib-2.0.so -Wl,--export-dynamic /usr/lib/libgmodule-2.0.so -pthread /usr/lib/libcairo.so /usr/lib/libgio-2.0.so /usr/lib/libgobject-2.0.so /usr/lib/libpango-1.0.so /usr/lib/libharfbuzz.so /usr/lib/libpangocairo-1.0.so /usr/lib/libxkbcommon.so /usr/lib/librsvg-2.so -lm /usr/lib/libgdk_pixbuf-2.0.so /usr/lib/libxcb.so /usr/lib/libxcb-util.so /usr/lib/libxcb-xkb.so /usr/lib/libxkbcommon-x11.so /usr/lib/libxcb-ewmh.so /usr/lib/libxcb-icccm.so /usr/lib/libxcb-xrm.so /usr/lib/libxcb-randr.so /usr/lib/libxcb-xinerama.so /usr/lib/libxcb-render.so /usr/lib/libstartup-notification-1.so -Wl,--end-group '-Wl,-rpath,$ORIGIN/subprojects/libgwater/xcb:$ORIGIN/subprojects/libnkutils' -Wl,-rpath-link,/home/hugh/Builds/rofi/build/subprojects/libgwater/xcb -Wl,-rpath-link,/home/hugh/Builds/rofi/build/subprojects/libnkutils
/usr/bin/ld: rofi@exe/source_rofi-icon-fetcher.c.o: in function `cairo_image_surface_create_from_jpeg_private':
/home/hugh/Builds/rofi/build/../source/rofi-icon-fetcher.c:143: undefined reference to `jpeg_read_header'
/usr/bin/ld: /home/hugh/Builds/rofi/build/../source/rofi-icon-fetcher.c:144: undefined reference to `jpeg_start_decompress'
/usr/bin/ld: /home/hugh/Builds/rofi/build/../source/rofi-icon-fetcher.c:154: undefined reference to `jpeg_read_scanlines'
/usr/bin/ld: /home/hugh/Builds/rofi/build/../source/rofi-icon-fetcher.c:168: undefined reference to `jpeg_finish_decompress'
/usr/bin/ld: /home/hugh/Builds/rofi/build/../source/rofi-icon-fetcher.c:169: undefined reference to `jpeg_destroy_decompress'
/usr/bin/ld: rofi@exe/source_rofi-icon-fetcher.c.o: in function `cairo_image_surface_create_from_jpeg':
/home/hugh/Builds/rofi/build/../source/rofi-icon-fetcher.c:184: undefined reference to `jpeg_std_error'
/usr/bin/ld: /home/hugh/Builds/rofi/build/../source/rofi-icon-fetcher.c:186: undefined reference to `jpeg_CreateDecompress'
/usr/bin/ld: /home/hugh/Builds/rofi/build/../source/rofi-icon-fetcher.c:187: undefined reference to `jpeg_stdio_src'
collect2: error: ld returned 1 exit status
[77/105] Compiling C object 'scrollbar.test@exe/meson-generated_theme-parser.c.o'.
ninja: build stopped: subcommand failed.

What behaviour you expect to see

• rofi builds successfully

Additional details: It seems the failure is something to do with either libjpeg (I have the Arch package libjpeg-turbo installed (version 2.0.4-1)) or cairo (I have version 1.17.2+17+g52a7c79fd-2 installed)

[DaveDavenport]

libjpeg is a new dependency, I see I forgot to add it to the meson build. Will do that.

[DaveDavenport]

added it.. Don't use meson myself, completely forgot it was there.

please confirm it works/doesn't work.

[hughwilliams94]

Bingo, thanks very much!

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.