search

davatorium / rofi

Rofi: A window switcher, application launcher and dmenu replacement
https://davatorium.github.io/rofi/
Other
13.04k stars 609 forks source link

[BUG] rofi takes 3s to starts, if icons are enabled #2005

Closed PerchunPak closed 2 months ago

PerchunPak commented 2 months ago

Rofi version (rofi -v)

1.7.5

Configuration

-no-config

Theme

-no-config

Timing report

https://gist.github.com/PerchunPak/203502ba0b2e82bbe8ceeb4fcbf055cf

Launch command

rofi -drun-use-desktop-cache -show drun -no-config -show-icons

Step to reproduce

Expected behavior

rofi should react instantly

Actual behavior

rofi doesn't react for 3 seconds (turn on sound)

https://github.com/user-attachments/assets/16627258-0f81-44d1-9d8e-1ca9185906e8

Additional information

The issue is the same if I remove -drun-use-desktop-cache

I use NixOS on unstable branch (https://github.com/NixOS/nixpkgs/commit/7e7c39ea35c5cdd002cd4588b03a3fb9ece6fad9) and hyprland v0.41.2 (which also means I use Wayland, I don't know why am I required to say that I don't even when wiki page says you support Wayland)

Using wayland display server protocol

I've checked if the issue exists in the latest stable release

PerchunPak commented 2 months ago

Also tried to build from source on 8eb8ff3 and it didn't help as well.

EDIT: Though build from next also takes a second to start even if I just use rofi -show drun -no-config (but if I enable icons, it starts even longer)

lbonn commented 2 months ago

@PerchunPak Which version of rofi was your original report for? (rofi -version)

Not sure it is related to the slowdown but there are two packages in nixpkgs, one with wayland support from the fork: https://github.com/NixOS/nixpkgs/tree/master/pkgs/applications/misc/rofi

If you were using mainline rofi for both of your tests, maybe try also with the wayland version with timing reports as well.

PerchunPak commented 2 months ago

oh yeah, rofi-wayland works. sorry for the confusion

DaveDavenport commented 2 months ago

(which also means I use Wayland, I don't know why am I required to say that I don't even when wiki page says you support Wayland)

Where does it say this? this should be fixed then.

PerchunPak commented 2 months ago

Where does it say this? this should be fixed then.

https://github.com/davatorium/rofi/blob/8eb8ff3b6f5e0639e20006161f1ae308414f0f70/.github/ISSUE_TEMPLATE/bug_report.yml?plain=1#L103

DaveDavenport commented 2 months ago

Sorry for being unclear, where in the wiki does it say we support wayland?

The question in the bug report is there as it helps pin-point problems and redirect people to the right issue tracker.

PerchunPak commented 2 months ago

Yes, something like "current release doesn't support wayland, so you should use the fork" would guide me in the right direction

DaveDavenport commented 2 months ago

like the current text on the wiki?

A pull request was opened to allow Rofi to work under Wayland with Sway and some other window managers. If you are are interested, check out the fork that was spun off from the PR and send your feedback there.

Sorry for being unclear, where in the wiki does it say we support wayland?

can you please point out where?

PerchunPak commented 1 month ago

Exactly here, changing it to would guide me in the right direction, because for some reason I didn't check linked PR and assumed it was merged

A pull request was opened to allow Rofi to work under Wayland with Sway and some other window managers, but it wasn't merged. If you need proper Wayland support, check out the fork that was spun off from the PR and send your feedback there.

(Changed parts are bold)

You can also ignore this as my skill issue, since I didn't know that PR was closed until now

DaveDavenport commented 1 month ago

Thanks, changed the text.

github-actions[bot] commented 3 weeks ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.