implement frecency sorting?

unhammer commented 7 years ago

Version

Version: 1.3.1

Configuration

https://gist.github.com/unhammer/a2484e704cdc05395d997ad7cd072490

Launch Command

rofi -modi combi -show combi -combi-modi "drun,run,ssh,window"

Steps to reproduce

Start caja four times from rofi
Let some weeks pass
Start corebird three times from rofi

What behaviour you see

after typing core, the top drun hit is Caja

What behaviour you expect to see

Corebird as the top drun hit, since it was used more recently.

I saw that frecency was mentioned in #194 , but the "fix" there was disabling Levenshtein sorting. I really like having Levenshtein on, though (also, it seems necessary to get drun matches on Name fields of .desktop files?). A better fix in my opinion would be to implement https://developer.mozilla.org/en-US/docs/Mozilla/Tech/Places/Frecency_algorithm (as used by Firefox and https://github.com/clvv/fasd). Simply sorting by most used means programs you stopped using will hang around and annoy you long afterwards.

DaveDavenport commented 7 years ago

FWIW: You can hit shift-delete to remove an item from history.

It is an interesting idea.

unhammer commented 7 years ago

FWIW: You can hit shift-delete to remove an item from history.

When I tried, this didn't seem to have an effect (I ended up just starting corebird a bunch more times, which "worked" …)

DaveDavenport commented 7 years ago

Weird works for me (tm) even in combi mode.

davatorium / rofi