search

davatorium / rofi

Rofi: A window switcher, application launcher and dmenu replacement
https://davatorium.github.io/rofi/
Other
13.04k stars 609 forks source link

Without fixed-num-lines rofi is not correctly centered #823

Closed memeplex closed 5 years ago

memeplex commented 6 years ago

Version: 1.5.1-dirty (tags/1.5.1)

Using fixed-num-lines=false rofi is no longer centered on the screen but positioned below the center, even if location = 0.

DaveDavenport commented 6 years ago

This is indeed correct. With fixed-num-lines it centers on the top of the window.

This was to avoid that the window would keep moving as you type and 'shrink' the list.

memeplex commented 6 years ago

I think, at least heuristically, placing the window a bit above the center (say on fourth or third of max lines) could work better, because currently rofi will be below the center for sure.

On Wed, Jun 27, 2018, 4:31 PM Dave Davenport notifications@github.com wrote:

This is indeed correct. With fixed-num-lines it centers on the top of the window.

This was to avoid that the window would keep moving as you type and 'shrink' the list.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DaveDavenport/rofi/issues/823#issuecomment-400802102, or mute the thread https://github.com/notifications/unsubscribe-auth/ACtq-Zfqr9imulWIpG7j5aj3Q-krgqE4ks5uA91_gaJpZM4U5-Dd .

DaveDavenport commented 6 years ago

It used to do that in older versions, but with the new theme format, the list can be anywhere. This heuristic won't work anymore.

memeplex commented 6 years ago

I was going to suggest about adding an optional percentage offset to the location option, but I see that's exactly what the theme configuration can do. I was happy with my old style color specification otherwise, but I guess I will have to move to a full fledged theme.

carnager commented 6 years ago

You can use rofi -dump-theme > $HOME/.local/share/rofi/themes/my_theme.rasi to store current theme in new format. This will also appear in rofi-theme-selector

memeplex commented 6 years ago

Rethinking about this. I have a couple of use cases in which I call rofi from other tools (i3, polybar) and, depending on the invocation, the position and the offset should change. Now the position can be passed as a command line argument but what about the offset? I think it's not a bad idea to let the offset be another config/cli parameter, not something necessarily coupled to a theme.

memeplex commented 6 years ago

Well, I now see there is the -theme-str option, that could be enough, I'll give it a try.

Besides, there are a couple of options not documented in the man page: xoffset, yoffset (although there is an example using yoffset in the man). Are they still supported?

DaveDavenport commented 6 years ago

That is a bug in the manpage then. They are still supported.

memeplex commented 6 years ago

Great, then we can close this, I suppose. Do you want me to open another issue for the man page?

On Wed, Jul 18, 2018, 5:32 AM Dave Davenport notifications@github.com wrote:

That is a bug in the manpage then. They are still supported.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DaveDavenport/rofi/issues/823#issuecomment-405853722, or mute the thread https://github.com/notifications/unsubscribe-auth/ACtq-eGYsHJfPe7JlA1AvctctYAO7cb_ks5uHvKjgaJpZM4U5-Dd .

DaveDavenport commented 5 years ago

I see 'x-offset' and 'y-offset' are in theme manual. closing.

github-actions[bot] commented 3 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.