davatron5000 / FitText.js

A jQuery plugin for inflating web type
http://fittextjs.com
6.75k stars 1.39k forks source link

"Fit Text Does Not Work" - Resolution: Widths want percentages not pixels! #109

Closed ahlswede closed 10 years ago

ahlswede commented 10 years ago

Short: FitText seems to only work with percentages, pixel sized containers will not be resized. It would be hugely helpful if the note on the repo reflected that you need a "percentage width" instead of just refering to width. I realize this might be obvious for some, but it would save a lot of people headache along the way!

Longer: I recently discovered this great tool and used it in one project successfully but then ran into issues on my second use. Having used the tool before I was pretty perplexed. I did some research and there was a lot of stack over flow issues with people having trouble but not very many answers.

Finally I discovered this gem: http://forum.jquery.com/topic/please-fittext-not-resize-the-fonts-contained-between-a-and-a

I tested their css solution and then picked it apart and the effective tag was the percentage width.

davatron5000 commented 10 years ago

I think FitText pretty clearly shows/demonstrates that it's intended for use in fluid designs. It should work with fixed pixels too.

Do you have a change in documentation that you'd like to propose?

ahlswede commented 10 years ago

Did some more testing and realized the issue was on my end. Feel free to delete this nonsense :)

Thanks for your time and the great tool!