davatron5000 / FitText.js

A jQuery plugin for inflating web type
http://fittextjs.com
6.75k stars 1.39k forks source link

Add spacing option for proportional letter spacing #127

Closed MathieuLoutre closed 8 years ago

MathieuLoutre commented 9 years ago

Currently maintaining a letter spacing in px for headlines with FitText is a little tricky at extreme resolution. I've added an option allowing to specify a spacing proportional to the font-size so that it always looks neatly spaced. Let me know if there are any changes required for merging.

davatron5000 commented 9 years ago

Thanks, Mathieu! This came up in #76, and it was determined that if proportional letter-spacing is a need then maybe browser supported em units are a better choice. Thoughts? Reduced test case?

MathieuLoutre commented 9 years ago

Sorry, I did a quick search but couldn't find this. em is definitely a better choice, no need to update this with JS if it can be done with em for sure. I didn't know I could have a font-size in px and a letter-spacing in em relative to it. That's great news! :) I'd say you can close it unless someone else can see a reason to have it set in JS. Thanks!