Invalid meta in bower.son

davatron5000 / FitText.js

A jQuery plugin for inflating web type

http://fittextjs.com

6.76k stars 1.39k forks source link

Invalid meta in bower.son #143

Closed teomaragakis closed 8 years ago

teomaragakis commented 8 years ago

bower invalid-meta  fittext is missing "main" entry in bower.json
bower invalid-meta  fittext is missing "ignore" entry in bower.son

CupOfTea696 commented 8 years ago

Additionally:

invalid-meta The "name" is recommended to be lowercase, can contain digits, dots, dashes

charliewilco commented 8 years ago

wonder if it'd be easier for people to grab this off npm and we could specify the jquery dependencies there.

any thoughts @davatron5000? how are you handling client side deps these days?

CupOfTea696 commented 8 years ago

Well bower is meant for front-end packages, and given that this is a package that will mainly be used in websites, grabbing it off bower makes more sense.

To quote from this great Stackoverflow answer:

So, the common usage is Bower for the packages that you want to publish on your webpages (e.g. runtime, where you avoid duplication), and use npm for other stuff, like testing, building, optimizing, checking, etc. (e.g. development time, where duplication is of less concern).

The full answer is a very interesting read if you're interested.

charliewilco commented 8 years ago

yes that's true but it's just as easy to grab it from npm, especially if you want to bundle and minify it and references it in your code. and it's becoming way more common place to do that.

this is also worth considering https://github.com/bower/bower/issues/2298

davatron5000 commented 8 years ago

Bower has been nothing but trouble to support. I'm looking moving FitVids over to npm as well https://github.com/davatron5000/FitVids.js/pull/211

But we probably need to support both for the meanwhile. I don't use Bower so it's a lot of mental energy to jump in a figure it out. Does anyone know how to fix this? Like are there bullet points? Update main, ignore, and name attributes? To what?

charliewilco commented 8 years ago

@davatron5000 will put some energy on it this after right now big guy, no worries.

charliewilco commented 8 years ago

try running bower cache clean && bower install jquery-fittext.js --save

adamscybot commented 8 years ago

That stack overflow post about how bower is "the" front end choice is now very outdated. A modern build process now involves all dependencies (front end or otherwise) being pulled from NPM then built using module loaders such as webpack and browserify. The latest changes also make NPM work similar to bower in terms of conflict resolution.

Its also not a choice of one or the other. Alls thats needs to be done is:

Package.json added to repo (npm init)
Make sure that the main declaration points to the main fittext js file.
Accommodate module loaders such as webpack that have module.exports in their environment. Easiest thing to do is implement Universal Module Definition. This gives you support for require.js environments as well. Theres even a specific jquery plugin example in that repo: https://github.com/umdjs/umd/blob/master/templates/jqueryPlugin.js
npm publish

graingert commented 8 years ago

npm is for JavaScript. There is no front-end or backend JavaScript, only code highly coupled to the DOM.

graingert commented 8 years ago

Please remove bower from this project as soon as possible

charliewilco commented 8 years ago

@graingert why?

teomaragakis commented 8 years ago

@charlespeters why what?

charliewilco commented 8 years ago

@teomaragakis really sorry about that; tagged the wrong person

@graingert why do we need to remove bower? if you want to use npm you totally can.

graingert commented 8 years ago

@charlespeters if bower has packages, people might use it

charliewilco commented 8 years ago

@graingert it's just a chance we'll have to take