search

davatron5000 / FitText.js

A jQuery plugin for inflating web type
http://fittextjs.com
6.75k stars 1.39k forks source link

Bug with Bootstrap's Open Dropdown Menu #164

Open michael-ecklund opened 7 years ago

michael-ecklund commented 7 years ago

In Bootstrap, it seems to only scale the font size if the menu is opened. If it's closed, there's no font scaling happening. (This is probably intended functionality -- because the items aren't visible).

I'd like to note two things:

  1. On initial page load, it isn't setting a font size to these list items in the dropdown. (Probably because it's closed and they're not visible).

  2. If a dropdown menu is "opened", the font is continuously enlarged on screen resize.

I haven't tested yet, but I would assume this true for all dynamically hidden/visible items on a page.

I love this script, but I also love using Bootstrap. It would be nice if it integrated well with Bootstrap's concepts.

michael-ecklund commented 7 years ago

For what it's worth, I set a JS event to know when the parent menu item was done setting font-size (using your script), then on that event... Set the font-size for the items in the dropdown menu (not using your script). So I got it working, but it was just an extra step. I wish I could have just applied a simple function call using your script to the dropdown items as well.