Google Closure Compiler

davatron5000 / FitVids.js

A lightweight, easy-to-use jQuery plugin for fluid width video embeds.

http://fitvidsjs.com

4.77k stars 986 forks source link

Google Closure Compiler #219

Open m0hamm4dElmi opened 9 years ago

m0hamm4dElmi commented 9 years ago

Hi, Thanks for this amazing plugin. When I wanted to optimize above code by Google Closure Compiler, I encounter 25 warnings which is attached. Do you have any idea to remove these warnings? https://www.dropbox.com/s/klvsc1w4w967kfx/fitvids.png?dl=0

Ward Regards

davatron5000 commented 9 years ago

@m0hamm4dElmi Looks like you don't have jQuery. That's what I'd guess if $.fn is not defined.

m0hamm4dElmi commented 9 years ago

Dear Davatron5000 I did not have any issue in working with fitdiv, in fact it works in perfect way. But I decide to minify it, when I’m trying to do that I encounter those mentioned errors (compressing in advanced mode shows the errors) that’s why I am bringing up this subject to see if there is a solution for it. I mean compressing in advanced mode with no warning. Hope to hear from you soon.

Best Regards

davatron5000 commented 8 years ago

@m0hamm4dElmi Can I get some steps to reproduce this? Totally understandable if you've moved on over the past year 😉