search

davatron5000 / FitVids.js

A lightweight, easy-to-use jQuery plugin for fluid width video embeds.
http://fitvidsjs.com
4.77k stars 986 forks source link

Flexbox Order & FitVids #241

Closed jezthomp closed 8 years ago

jezthomp commented 8 years ago

Is this a known issue that when flex box ordering is applied it collapses the container of the FitVid and other content slides behind as its doesn’t have a height?

davatron5000 commented 8 years ago

@jezthomp Do you have a reduced test case?

jezthomp commented 8 years ago

No sorry, its local. Essentially a 2 column grid once on mobile it collapses down but re-ordered with flex box. The fitvids container if within column 2 its purpose is just for the video, not for the column width. Once i re-order on mobile the column 2 loses its height and collapses i assume because of the padding added to the video container via FitVids

jezthomp commented 8 years ago

Ignore, my css was wrong.

davatron5000 commented 8 years ago

@jezthomp Glad you got it figured out! Thanks again.