search

davbai / twitter-client

0 stars 0 forks source link

[Intro to iOS] Project 3 #1

Open davbai opened 10 years ago

davbai commented 10 years ago

App complete, /cc: @thecodepath

sandofsky commented 10 years ago

Overall, looks great.

Within the Tweet and User objects, I'd recommend not using optionals for variables like text and the creation string. They should always be present. If they aren't, it's better to fail fast.

Also, in the Tweet Class, NSDateFormatter is instanced with every Tweet. NSDateFormatter is actually pretty expensive to instance, so it's common to cache a static instance and reuse that through the app.

I wouldn't place authentication logic on the User object. I'd probably attach that to the TwitterClient, so that one object houses all the authentication related logic.

For the tweet table view cell, I recommend just having "tweet" property on TweetTableViewCell, similar to what you're doing with TweetDetailView. Within TweetDetailView, I'd recommend refactoring that "setTweet" logic into a property observer.