search

davbeck / TUSafariActivity

A UIActivity subclass that opens URLs in Safari
Other
311 stars 71 forks source link

move Localizations & Resources to bundle #10

Closed 343max closed 10 years ago

343max commented 10 years ago

moved all the translations and images to its own .bundle

this fixes a bug, where my apps translations did not work anymore for localizations that where available in TUSafariActivity but not in my main app.

herrernst commented 10 years ago

Hi, unfortunately, localizations do not work for me anymore with this change, but only on the device, on the simulator they do, but I don't really know why. It seems that localizations only get loaded from the main bundle. For a possible solution see http://stackoverflow.com/a/16210023/270420, although I don't know what would be considered as best practice for cocoapods. Maybe you could also use the NSLocalizedStringFromTableInBundle macro, which is used here for example: https://github.com/eager/appirater/commit/cc127a10fd1931eddb04a13e08eed1243ec0f5bd

herrernst commented 10 years ago

This commit fixes it for me: https://github.com/herrernst/TUSafariActivity/commit/e779977ea090986be62bbac3c354dbed38010f74