search

davdroman / Bohr

Settings screen composing framework
MIT License
1.26k stars 83 forks source link

Added PickerView with expansion cell #20

Closed Niko-r closed 4 years ago

davdroman commented 8 years ago

I see what you're trying to do here. It's a pretty good idea, but I think we can take it further.

What if we added this functionality to BOChoiceTableViewCell as an optional way to choose an option? I can think of a mode property defining whether the cell works via taps or the picker view itself.

What do you think?

mythodeia commented 8 years ago

@DavdRoman excellent idea! this way the user would be able to choose a preferred way

davdroman commented 8 years ago

Good to hear your thoughts, @mythodeia :smile:

Niko-r commented 8 years ago

@DavdRoman at the beginning I was shared between including it into BOChoiceTableViewCell, or make it "independent" in case it would be pushed further in customization/functionnalities. A mode option is a good idea, and I'm fine with it if you want to go this way ;-)

davdroman commented 8 years ago

Exactly my thoughts too, although I think the case is simple enough to mix it into a simple cell.