search

davdroman / DRCellSlideGestureRecognizer

Make your cells actionable through swipes
MIT License
519 stars 45 forks source link

CocoaPods support #2

Closed dlackty closed 11 years ago

dlackty commented 11 years ago

Hello, I would like to help you write a CocoaPods podspec for this library, but need to make sure:

  1. As described in README file, you intended to release this library without any license like MIT (the most common one) but make it in the public domain?
  2. Any plan to add a git tag (e.g. 0.1.0) to a commit as the first official version release?
  3. Which iOS version is required for PDGesturedTableView? As I read the code, I guessed it should work on iOS > 6.
davdroman commented 11 years ago

Hi! Thanks for helping me.

  1. Yes, I want to release the library without any license.
  2. I don't know exactly what git tags are. Could you explain it to me, please?
  3. Yes. It should work perfectly on iOS 6 and newer.
dlackty commented 11 years ago

Sure. Git tag is a way to create meaningful version numbers on commits. For example, you can tag the current HEAD (latest commit in the branch) as, for instance, version 1.0.0, like so:

git tag -a 1.0.0 -m "Some description of this version"
git push --tags

You could find some more information on http://git-scm.com/book/en/Git-Basics-Tagging

Once you have done that, you could see the version tags in the following page: https://github.com/Dromaguirre/PDGesturedTableView/releases

davdroman commented 11 years ago

Oh I see. Looks pretty useful.

Ok so I'll tag the current HEAD as 0.1, for instance. I'll make it 1.0 when the "moving cells with a long press gesture" thing is implemented.

dlackty commented 11 years ago

Look forward to that. Long press move will be a great feature. Let me know once you push any tags then I could write a podspec for you. :+1:

davdroman commented 11 years ago

Done :+1:

dlackty commented 11 years ago

It's available on CocoaPods now! :smile:

https://github.com/CocoaPods/Specs/blob/master/PDGesturedTableView/0.1/PDGesturedTableView.podspec https://twitter.com/CocoaPods/status/393457500386652160

dlackty commented 11 years ago

FYI: I found that PDGesturedTableView actually requires iOS >= 7 as there're both firstObject: and setSeparatorInset: that are only available in iOS 7.

That's fine for me, and I just updated CocoaPods's podspec for this version requirement.

davdroman commented 11 years ago

Yeah, that's right! Thanks for fixing it :+1: