dave-code-ruiz / elkbledom

Home Assistant custom component for LED STRIP NAME ELK BLEDOM
MIT License
77 stars 16 forks source link

Effect reset when changing brightness #26

Closed dave-dube closed 1 year ago

dave-dube commented 1 year ago

If i set en effect (eg: blink_green), the led are starting linking green. nice. But if i change brightness the effect is stopped and led are back in "full green". So impossible to change brightness when using effects Using this Led strip:

dave-code-ruiz commented 1 year ago

Yes, impossible to change brightness when using effects, I'll check it when I have some time

dave-code-ruiz commented 1 year ago

I think the strip can't do it or i can't how to develop.

Can you test if app or remote permit effect and change brightness without stop effect ??

Set effect write([0x7e, 0x00, 0x03, value, 0x03, 0x00, 0x00, 0x00, 0xef]) Set brightness write([0x7e, 0x00, 0x05, 0x02, color_temp_percent, brightness_percent, 0x00, 0x00, 0xef]) I can´t set constant values 0x03 and 0x05 at the same time

Thks

dave-dube commented 1 year ago

Hello.

Yes i can do few test. using the Remote, yes i can change the brightness during using effects, and the effects is not stopped. So for sure using the remote it works.

now, to test using apps..... i will need probably your help to know which (and how) test i should do.

Thanks

ynsgnr commented 1 year ago

This should fix it: https://github.com/dave-code-ruiz/elkbledom/pull/41

dave-dube commented 1 year ago

Thanks @ynsgnr. I installed manually your 2 new files on my environment and did few tests. Everything works fine and now the effect is not reset anymore when changing brightness. Thanks so much