Changing brightness slowly ruins the color - Githubissues

dave-code-ruiz / elkbledom

Home Assistant custom component for LED STRIP NAME ELK BLEDOM

MIT License

77 stars 16 forks source link

Changing brightness slowly ruins the color #30

Closed Double-A-92 closed 1 year ago

Double-A-92 commented 1 year ago

When I change the brightness with the "Light" panel on my home view, the set color slowly degrades towards pure Red, pure Blue or pure Green.

E.g.

Set a white-ish color at 100%
Change it to 1%
Change it back to 100%
Color becomes a bit more orange
Change it to 1% and back to 100%
Color becomes more red
Repeat a few times
Color is pure Red

In real life this color has become Red at 30%

Maybe some rounding or integer division error while calculating the new RGB value?

ynsgnr commented 1 year ago

This should fix it: https://github.com/dave-code-ruiz/elkbledom/pull/41