dave-code-ruiz / elkbledom

Home Assistant custom component for LED STRIP NAME ELK BLEDOM
MIT License
81 stars 17 forks source link

implemented setting actual brightness #41

Closed ynsgnr closed 1 year ago

ynsgnr commented 1 year ago

This PR Implements setting the actual brightness instead of setting an RGB color

Since actual brightness is set it also applies to brightness of effects playing, brightness of RGB and white at once. It also doesn't stop the effect from playing anymore

I tested this with StripX (the new model was mentioned in https://github.com/dave-code-ruiz/elkbledom/issues/11, and its different from Strip controller) but I assume it will work in older models as well.

dave-code-ruiz commented 1 year ago

Thnks @ynsgnr

ynsgnr commented 1 year ago

@dave-code-ruiz please test it with the ELK (strip) light, I'm not sure if it will work %100 😅

I only have a MELK (stripX) light

dave-code-ruiz commented 1 year ago

It's too late, hahaha

I will test it this night

dave-code-ruiz commented 1 year ago

Release 1.1.2 is burning

ynsgnr commented 1 year ago

Release 1.1.2 is burning

Ship it! LoL, hope it works thought