dave-code-ruiz / uhomeuponor

Custom Component to connect Home Assistant with Uhome Uponor Smatrix App
MIT License
19 stars 7 forks source link

Feature: Expose this in HACS #2

Closed LordMike closed 4 years ago

LordMike commented 4 years ago

https://hacs.xyz/docs/publish/start

Requirements:

Looks like hacs.json just has to be:

{
  "name": "Uhome",
  "render_readme": true,
  "domains": ["sensor", "climate"]
}
dave-code-ruiz commented 4 years ago

I try to expose in HACS, i think i do all steps correct

i waiting for a response

LordMike commented 4 years ago

I think you need to add a PR here, https://github.com/hacs/default/pulls.

In any case. It can be tested now, by adding the repo in HACS (on an HA server). Can be used to test.

LordMike commented 4 years ago

I just tried adding the repo & installing the integration via. HACS, it didn't work. At least not with my current configuration.

EDIT: Scratch that. Bad test. It works.

LordMike commented 4 years ago

I've added a PR that updates the docs, and adds the necessary hacs.json file. I cannot add a PR towards the default repos, as I'm not an Owner of this repository. So to complete this, @dave-code-ruiz can do the PR instead of me.

dave-code-ruiz commented 4 years ago

Agregué un RP que actualiza los documentos y agrega el hacs.jsonarchivo necesario . No puedo agregar un RP hacia los repositorios predeterminados, ya que no soy propietario de este repositorio. Para completar esto, @ dave-code-ruiz puede hacer el PR en lugar de mí.

Sorry for taking so long

https://github.com/hacs/default/pull/225

I do it now

Can you review why checks fail in .github file? Thnks

https://github.com/hacs/default/pull/225/checks?check_run_id=442987957

LordMike commented 4 years ago

Yeap, you're missing a comma, "," after your text in the integrations file.

dave-code-ruiz commented 4 years ago

incredible, my mind is getting worse

thnks