search

dave-howard / vsdx

vsdx - A python library for processing .vsdx files
BSD 3-Clause "New" or "Revised" License
67 stars 25 forks source link

Implement Shape.__eq__() and consequently Shape.__hash__(). fix #32 #34

Closed stevensultana closed 2 years ago

stevensultana commented 2 years ago

Should we also check that the vsdx file is the same? Feels like overkill.

dave-howard commented 2 years ago

Hi @stevensultana - I'll take a look, and merge with latest changes,

I do think, ideally, that shape equality should take into account shape id, page and file path too - so I might include that on merge if it's as simple as including file path in the hash/eq methods.

Thanks Dave