Fix copy_shape() for group of shapes

dave-howard / vsdx

vsdx - A python library for processing .vsdx files

BSD 3-Clause "New" or "Revised" License

70 stars 25 forks source link

Fix copy_shape() for group of shapes #9

Closed stevensultana closed 3 years ago

stevensultana commented 3 years ago

Fix VisioFile.copy_shape() to save changes to page after copying a shape.

Fix VisioFile.set_page_max_id() to consider groups inside group.

Add VisioFile.get_shape_max_id() as helper function.
Use Element.find() to simplify code.
Add tests for grouped shapes.

dave-howard commented 3 years ago

Apologies for the delay, this PR merged and tested - looks good. Element.find()/findall() is definitely the way to go. Note I added a couple of new tests in latest commit to test finding elements using xpath as ElementTree is new for me.

stevensultana commented 3 years ago

ElementTree is new for me too, to be honest. I had already done some work looking to changing the codebase to find()/findall(), gotta pick it up again where I left it off.