search

dave-kennedy / clean-html

HTML cleaner and beautifier for Node
The Unlicense
47 stars 10 forks source link

Maximum call stack exceeded #3

Closed Nantris closed 7 years ago

Nantris commented 7 years ago

Thanks for the excellent tool. I find when I paste more than 2 dozen or so lines, I get a maximum callstack exceeded error. Any thoughts of fixing this?

Thanks again!

dave-kennedy commented 7 years ago

Can you provide a sample so I can repro?

dave-kennedy commented 7 years ago

Actually, you might be running into a bug I fixed in 64ac394. Please pull down that version and see if it works for you.

Nantris commented 7 years ago

Hey Dave. Thanks very much for the update. I'll try out the new version and if I'm still hitting the issue I'll make an example repo when I can.

Thanks again for the great library! It's a great thing to have on hand. Must have saved me days and days of coding.

Nantris commented 7 years ago

Are you planning to release a versioned update I could pull via npm/yarn?

dave-kennedy commented 7 years ago

Yep, as soon as we can verify this bug is squashed. I was also hoping to address #4 and #5 in the next release, but I can publish sooner if it helps.

dave-kennedy commented 7 years ago

I published a new version (or three) to npm. Let me know if you're still having problems.

Nantris commented 7 years ago

Thanks a lot @dave-kennedy.

That will let me test it sooner. It will be a few days before I can give it a proper test.

dave-kennedy commented 7 years ago

Closed due to inactivity.

Nantris commented 7 years ago

Whoops thanks for updating the status of this. Yes the update did fix the issue. Sorry for not posting back. Great dev. I really appreciate the update you wrote to fix this issue.