Upgrade Virtualmin please!

dave-lang / webmin-docker

Docker module for Webmin

MIT License

38 stars 11 forks source link

Upgrade Virtualmin please! #2

Open PauloBoaventura opened 7 months ago

PauloBoaventura commented 7 months ago

Hello... I really liked your code... But... One thing was missing... Virtualmin is very essential... Would it be possible to adapt the code to Virtualmin?

dave-lang commented 6 months ago

Hi,

I don't actually use virtualmin, happy to review and merge a PR if you can make the changes though. Otherwise point me at the docs and I'll take a look

Lawkss commented 5 months ago

virtualmin basically includes webmin, so you can still use this module.

dave-lang commented 5 months ago

Looking through https://www.virtualmin.com/docs/development/creating-plugins/#feature_webmindomain-other-domains it appears it should work.

I will try to test, can't guarantee when though.