search

dave-p / TVHadmin-JS

A javascript front-end for Tvheadend, inspired by VDRadmin
GNU General Public License v3.0
29 stars 7 forks source link

Tolerate invalid JSON response from EPG API #2

Open jlsalmon opened 3 years ago

jlsalmon commented 3 years ago

First off, thanks for creating TVHadmin-JS! I use it on a daily basis, and it's so much better than the built-in THHeadend EPG. Great work.

Quite frequently (several times per day for me) the Timeline view fails to render, because the EPG API returns an invalid JSON body. It appears that there are some strange control characters being returned in the summary and subtitle fields. This simple patch strips out the ASCII control character range from the API response before attempting to parse the string as JSON. This fixes my issue, and hopefully will be useful to others with the same issue.

I hope you can find the time to review this small contribution - Thanks in advance!

dave-p commented 3 years ago

What version of Tvheadend are you using? This issue (or something like it) was fixed in Tvheadend about two years ago - see https://tvheadend.org/issues/5366 and https://github.com/tvheadend/tvheadend/pull/1270. However if it is a new problem then it would be simpler to fix here - Tvheadend development has pretty much stopped.

jlsalmon commented 3 years ago

I’m using v4.2.8, the latest available in the Debian buster repo. AFAIK v4.3 isn’t released yet (and maybe never will be)? I did build v4.3 manually a while ago, but it had a bunch of other issues that caused me to go back to v4.2. I admit that I didn’t check to see if this issue happened in v4.3, so you could well be right that this is already fixed upstream. Shame that tvheadend development has stopped :(

On 24 Aug 2021, at 10:19, dave-p @.***> wrote:

 What version of Tvheadend are you using? This issue (or something like it) was fixed in Tvheadend about two years ago - see https://tvheadend.org/issues/5366 and tvheadend/tvheadend#1270. However if it is a new problem then it would be simpler to fix here - Tvheadend development has pretty much stopped.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.